Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better charmap selection #25

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Better charmap selection #25

merged 1 commit into from
Jul 31, 2022

Conversation

chelnak
Copy link
Owner

@chelnak chelnak commented Jul 21, 2022

Prior to this PR it was possible to mutate the charmaps stored in the charmap package because they were exported vars.

This commit changes the behaviour so that slices are retrieved by a lookup method.

@chelnak
Better charmap selection
757e831 
Prior to this commit it was possible to mutate the charmaps stored in
the charmap package because they were exported vars.

This commit changes the behaviour so that slices are retrieved by a
lookup method.
@chelnak chelnak added the enhancement New feature or request label Jul 21, 2022
@chelnak chelnak self-assigned this Jul 21, 2022
@chelnak chelnak merged commit 4a5b7aa into main Jul 31, 2022
@chelnak chelnak deleted the charmap_selection branch July 31, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chelnak chelnak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chelnak